Testcase for the nodeinfo endpoint

dachary · October 18, 2021, 2:52am

I wrote a tiny testcase for the nodeinfo endpoint and it passes the CI.

Since I do not have a GitHub account, I would be most grateful if you could create a pull request on my behalf with the following:

Subject: api: integration test for nodeinfo
Description: Add a minimal integration test for the nodeinfo endpoint added in https://github.com/go-gitea/gitea/pull/16953
Commit: 0002-api-integration-test-for-nodeinfo.patch (1.6 KB)

This is tedious and I would absolutely understand if you don’t have the bandwidth to do that right now. I can always ask around for help

Cheers

techknowlogick · October 18, 2021, 3:02am

Oh, this is wonderful. Thank you so much. I will submit the PR now.

It was ~5s to submit to commit, so no worries. Please feel free to ask again if you wish to submit upstream (we recently had a successful PR merge for the multiple github API for migration away, so with luck the next migration test to gitea.com will be successful and we will be ever so closer to moving off of github).

techknowlogick · October 18, 2021, 3:03am

Submitted: https://github.com/go-gitea/gitea/pull/17346/files

dachary · October 18, 2021, 6:53am

I’m impressed that it was merged so quickly.